Deprecate the entered prop on the Transition component
#3089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We keep the `enterTo` classes once the `enter` transition finishes - We keep the `leaveTo` classes once the `leave` transition finishes
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thecrypticace
approved these changes
Apr 9, 2024
This was referenced May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR marks the
enteredprop on theTransitioncomponent as deprecated. This prop was used to ensure that some classes stay after the transition finishes.However, it makes more sense to use the
enterToandleaveToclasses to achieve the same effect. This was already implemented, so there is no need for theenteredprop at all. We keep it for backwards compatibility reasons, but marking it as deprecated such that you can drop it from your own codebase if you want.Quick summary:
enterToclasses once theentertransition finishesleaveToclasses once theleavetransition finishes